coffey-labs/ihasmail
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Match Shift+letter shortcuts (Shift+I, Shift+U) (#399)

Browse Source 
comboOf() let a shifted letter encode Shift in its case, so Shift+I
produced "I" and never matched the "shift+i" / "shift+u" bindings for
mark as read / unread. Shifted letters now yield "shift+<letter>";
symbols such as "#" and "!" still carry Shift in the character.

Fixes #398

Co-authored-by: Joe Esteves <[email protected]>
This commit is contained in:
jcoffey
2026-09-18 08:22:13 -07:00
committed by GitHub
co-authored by joeesteves
parent 2740129c6a
commit c118184975
3 changed files with 26 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web/src/lib/input/keyboard.ts
+4 -3
View File
@@ -145,13 +145,14 @@ export function comboOf(e: KeyboardEvent): string | null {
const mod = isMac ? e.metaKey : e.ctrlKey;
if (mod) parts.push("mod");
if (e.altKey) parts.push("alt");
if (e.shiftKey && key.length > 1) parts.push("shift");
const shiftedLetter = e.shiftKey && /^[a-z]$/i.test(key);
if (e.shiftKey && (key.length > 1 || shiftedLetter)) parts.push("shift");
let k = key;
if (k === " ") k = "space";
else if (k === "Escape") k = "esc";
else if (k.length === 1) {
// Single chars: shift is encoded by the character itself (e.g. "#", "!").
k = k.length === 1 && !e.shiftKey ? k.toLowerCase() : k;
// Symbols encode Shift in the character itself (e.g. "#", "!").
k = shiftedLetter || !e.shiftKey ? k.toLowerCase() : k;
} else k = k.toLowerCase();
parts.push(k);
return parts.join("+");