Use an example address, and the right name, in the test fixtures
Two things, one of them not what it looked like. An organizer fixture was built from a real, routable address. Every other fixture in the codebase uses example.org or example.com, and this repository is public, so that one was a personal address sitting in public source for no reason -- the test asserts roles and participation status and never reads either value. It is [email protected] now. The names were wrong in the other direction. Three fixtures across two files said "John Ellis", which is not the maintainer's name; it is John Coffey. Being a name rather than a routable address, it leaked nothing, but it was simply incorrect, and incorrect in the sort of place nobody rereads. The address and the name are separate questions and got separate answers: the address is fictional because it is an address, and the name is real because it is right. A message from [email protected] signed John Coffey is exactly what these tests mean. Found while checking, at the maintainer's prompting, whether the repo leaked anything about the host it runs on. It does not -- the nginx and deploy files here are the generic examples they claim to be, and the real ones live in a private repository.
This commit is contained in:
@@ -77,7 +77,7 @@ describe("what it refuses to acknowledge", () => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
const OPTS = {
|
const OPTS = {
|
||||||
from: { name: "John Ellis", email: "[email protected]" } as EmailAddress,
|
from: { name: "John Coffey", email: "[email protected]" } as EmailAddress,
|
||||||
to: { name: null, email: "[email protected]" } as EmailAddress,
|
to: { name: null, email: "[email protected]" } as EmailAddress,
|
||||||
finalRecipient: "[email protected]",
|
finalRecipient: "[email protected]",
|
||||||
reportingUa: "mail.example.org; ihasmail 2.0",
|
reportingUa: "mail.example.org; ihasmail 2.0",
|
||||||
|
|||||||
@@ -3,14 +3,14 @@ import { buildMarkerSignature, byteLength, compactHtml, markerOf, signatureTooLo
|
|||||||
|
|
||||||
describe("signature compaction", () => {
|
describe("signature compaction", () => {
|
||||||
it("strips office cruft and non-essential styles but keeps colours and links", () => {
|
it("strips office cruft and non-essential styles but keeps colours and links", () => {
|
||||||
const src = `<!--[if gte mso 9]><xml>x</xml><![endif]--><div class="WordSection1" style="mso-margin-top-alt:auto;line-height:115%;font-family:'Calibri',sans-serif;color:windowtext"><p class="MsoNormal" style="margin:0cm;font-size:11pt"><span lang="EN-US" style="font-size:12pt;color:#1F4E79;mso-fareast-language:EN-US"><b>John Ellis</b></span><o:p></o:p></p><p><span></span></p><a href="https://linuxexpert.org" target="_blank" data-x="1">linuxexpert.org</a><img src="https://x/y.png" width="100" style="mso-foo:bar"></div>`;
|
const src = `<!--[if gte mso 9]><xml>x</xml><![endif]--><div class="WordSection1" style="mso-margin-top-alt:auto;line-height:115%;font-family:'Calibri',sans-serif;color:windowtext"><p class="MsoNormal" style="margin:0cm;font-size:11pt"><span lang="EN-US" style="font-size:12pt;color:#1F4E79;mso-fareast-language:EN-US"><b>John Coffey</b></span><o:p></o:p></p><p><span></span></p><a href="https://linuxexpert.org" target="_blank" data-x="1">linuxexpert.org</a><img src="https://x/y.png" width="100" style="mso-foo:bar"></div>`;
|
||||||
const out = compactHtml(src);
|
const out = compactHtml(src);
|
||||||
expect(out).not.toContain("mso-");
|
expect(out).not.toContain("mso-");
|
||||||
expect(out).not.toContain("class=");
|
expect(out).not.toContain("class=");
|
||||||
expect(out).not.toContain("<xml");
|
expect(out).not.toContain("<xml");
|
||||||
expect(out).not.toContain("o:p");
|
expect(out).not.toContain("o:p");
|
||||||
expect(out).toContain("color:#1F4E79");
|
expect(out).toContain("color:#1F4E79");
|
||||||
expect(out).toContain("<b>John Ellis</b>");
|
expect(out).toContain("<b>John Coffey</b>");
|
||||||
expect(out).toContain('href="https://linuxexpert.org"');
|
expect(out).toContain('href="https://linuxexpert.org"');
|
||||||
expect(out).toContain('width="100"');
|
expect(out).toContain('width="100"');
|
||||||
expect(out.length).toBeLessThan(src.length / 2);
|
expect(out.length).toBeLessThan(src.length / 2);
|
||||||
|
|||||||
@@ -41,7 +41,7 @@ describe("makeParticipant", () => {
|
|||||||
expect(guest.expectReply).toBe(true);
|
expect(guest.expectReply).toBe(true);
|
||||||
});
|
});
|
||||||
it("marks the organizer as owner and keeps a status already given", () => {
|
it("marks the organizer as owner and keeps a status already given", () => {
|
||||||
const me = makeParticipant("[email protected]", "John Doe", "owner");
|
const me = makeParticipant("[email protected]", "John Coffey", "owner");
|
||||||
expect(me.roles).toEqual({ owner: true, attendee: true });
|
expect(me.roles).toEqual({ owner: true, attendee: true });
|
||||||
expect(me.participationStatus).toBe("accepted");
|
expect(me.participationStatus).toBe("accepted");
|
||||||
expect(me.expectReply).toBe(false);
|
expect(me.expectReply).toBe(false);
|
||||||
|
|||||||
Reference in New Issue
Block a user