From e4b6413f469b8c771848d0db0c1374e29942e178 Mon Sep 17 00:00:00 2001 From: John Coffey Date: Thu, 27 Aug 2026 14:09:12 -0700 Subject: [PATCH 1/2] Use an example address in the participants fixture One test built its organizer from a real, routable address and a real name. Every other fixture in the codebase uses example.org or example.com, and this repository is public, so the odd one out was a personal address sitting in public source for no reason -- the test asserts roles and participation status and never looks at either value. Now john@example.org, matching what the rest of the tests already use. Found while checking, at the maintainer's prompting, whether the repo leaked anything about the host it runs on. It does not: the nginx and deploy files here are the generic examples they claim to be, and the real ones live in a private repository. This was the only thing the search turned up that was worth changing. --- web/src/store/__tests__/participants.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/src/store/__tests__/participants.test.ts b/web/src/store/__tests__/participants.test.ts index 9796ed9..a04b4c0 100644 --- a/web/src/store/__tests__/participants.test.ts +++ b/web/src/store/__tests__/participants.test.ts @@ -41,7 +41,7 @@ describe("makeParticipant", () => { expect(guest.expectReply).toBe(true); }); it("marks the organizer as owner and keeps a status already given", () => { - const me = makeParticipant("john@linuxexperts.net", "John Coffey", "owner"); + const me = makeParticipant("john@example.org", "John Doe", "owner"); expect(me.roles).toEqual({ owner: true, attendee: true }); expect(me.participationStatus).toBe("accepted"); expect(me.expectReply).toBe(false); From a2337f6ad8e824d95fed40f28f454bcc6fd5db84 Mon Sep 17 00:00:00 2001 From: John Coffey Date: Thu, 27 Aug 2026 14:15:00 -0700 Subject: [PATCH 2/2] Use an example address, and the right name, in the test fixtures Two things, one of them not what it looked like. An organizer fixture was built from a real, routable address. Every other fixture in the codebase uses example.org or example.com, and this repository is public, so that one was a personal address sitting in public source for no reason -- the test asserts roles and participation status and never reads either value. It is john@example.org now. The names were wrong in the other direction. Three fixtures across two files said "John Ellis", which is not the maintainer's name; it is John Coffey. Being a name rather than a routable address, it leaked nothing, but it was simply incorrect, and incorrect in the sort of place nobody rereads. The address and the name are separate questions and got separate answers: the address is fictional because it is an address, and the name is real because it is right. A message from john@example.org signed John Coffey is exactly what these tests mean. Found while checking, at the maintainer's prompting, whether the repo leaked anything about the host it runs on. It does not -- the nginx and deploy files here are the generic examples they claim to be, and the real ones live in a private repository. --- web/src/lib/__tests__/mdn.test.ts | 2 +- web/src/lib/__tests__/signatureHtml.test.ts | 4 ++-- web/src/store/__tests__/participants.test.ts | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/web/src/lib/__tests__/mdn.test.ts b/web/src/lib/__tests__/mdn.test.ts index f71156f..b0222fd 100644 --- a/web/src/lib/__tests__/mdn.test.ts +++ b/web/src/lib/__tests__/mdn.test.ts @@ -77,7 +77,7 @@ describe("what it refuses to acknowledge", () => { }); const OPTS = { - from: { name: "John Ellis", email: "john@example.org" } as EmailAddress, + from: { name: "John Coffey", email: "john@example.org" } as EmailAddress, to: { name: null, email: "ann@example.com" } as EmailAddress, finalRecipient: "john@example.org", reportingUa: "mail.example.org; ihasmail 2.0", diff --git a/web/src/lib/__tests__/signatureHtml.test.ts b/web/src/lib/__tests__/signatureHtml.test.ts index 6f073b6..6cab445 100644 --- a/web/src/lib/__tests__/signatureHtml.test.ts +++ b/web/src/lib/__tests__/signatureHtml.test.ts @@ -3,14 +3,14 @@ import { buildMarkerSignature, byteLength, compactHtml, markerOf, signatureTooLo describe("signature compaction", () => { it("strips office cruft and non-essential styles but keeps colours and links", () => { - const src = `

John Ellis

linuxexpert.org
`; + const src = `

John Coffey

linuxexpert.org
`; const out = compactHtml(src); expect(out).not.toContain("mso-"); expect(out).not.toContain("class="); expect(out).not.toContain("John Ellis"); + expect(out).toContain("John Coffey"); expect(out).toContain('href="https://linuxexpert.org"'); expect(out).toContain('width="100"'); expect(out.length).toBeLessThan(src.length / 2); diff --git a/web/src/store/__tests__/participants.test.ts b/web/src/store/__tests__/participants.test.ts index a04b4c0..4fcfabe 100644 --- a/web/src/store/__tests__/participants.test.ts +++ b/web/src/store/__tests__/participants.test.ts @@ -41,7 +41,7 @@ describe("makeParticipant", () => { expect(guest.expectReply).toBe(true); }); it("marks the organizer as owner and keeps a status already given", () => { - const me = makeParticipant("john@example.org", "John Doe", "owner"); + const me = makeParticipant("john@example.org", "John Coffey", "owner"); expect(me.roles).toEqual({ owner: true, attendee: true }); expect(me.participationStatus).toBe("accepted"); expect(me.expectReply).toBe(false);