coffey-labs/ihasmail
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Look tags up by exact ref in the weekly release

Browse Source 
The dry run reported tag v2026.9.20-gc927c69 as existing when it did not.
On the git in the job image (2.39), rev-parse --verify refs/tags/<name>
falls back to reading a name ending in -g<hex> as git-describe output, and
resolves it to that commit. Every commit not merged through a pull request
gets a -g<hex> version, so every such week would have been skipped as
already released -- silently, since skipping is a normal outcome.

show-ref --verify matches an exact ref and nothing else. Both tag checks
use it now. release.yml has the same code; it only worked because GitHub's
runners carry a newer git that does not fall back.
This commit is contained in:
jcoffey-dev
2026-09-20 23:20:59 -07:00
parent c927c69fe2
commit 874d25a40c
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.gitlab-ci.yml
+10 -2
View File
@@ -190,7 +190,15 @@ weekly-release:
# A release can outlive its tag. Falling back to the whole history # A release can outlive its tag. Falling back to the whole history
# over-counts, which cuts a release that was due anyway; under-counting # over-counts, which cuts a release that was due anyway; under-counting
# would skip one that was. # would skip one that was.
if [ -n "$previous" ] && git rev-parse -q --verify "refs/tags/${previous}" >/dev/null; then # Tag lookups use show-ref, which matches an exact ref and nothing else.
# `rev-parse --verify refs/tags/<name>` does not: on the git in this image
# (2.39) a name ending in -g<hex> falls back to being read as
# git-describe output, resolves to that commit, and so "exists" whether
# or not the tag does. Every commit not merged through a pull request has
# a -g<hex> version, so that check reported every such week as already
# released. Newer git (and GitHub's runners) do not fall back, which is
# why release.yml never showed it.
if [ -n "$previous" ] && git show-ref --verify --quiet "refs/tags/${previous}"; then
count="$(git rev-list --count "${previous}..HEAD")"; range="${previous}..HEAD" count="$(git rev-list --count "${previous}..HEAD")"; range="${previous}..HEAD"
else else
count="$(git rev-list --count HEAD)"; range="HEAD" count="$(git rev-list --count HEAD)"; range="HEAD"
@@ -204,7 +212,7 @@ weekly-release:
if [ "$count" -eq 0 ]; then if [ "$count" -eq 0 ]; then
echo "Nothing to release: no commits since ${previous}."; exit 0 echo "Nothing to release: no commits since ${previous}."; exit 0
fi fi
if git rev-parse -q --verify "refs/tags/${tag}" >/dev/null; then if git show-ref --verify --quiet "refs/tags/${tag}"; then
echo "Nothing to release: tag ${tag} already exists."; exit 0 echo "Nothing to release: tag ${tag} already exists."; exit 0
fi fi
echo "Releasing ${tag} -- ${count} commit(s) since ${previous:-the beginning}, at ${sha}." echo "Releasing ${tag} -- ${count} commit(s) since ${previous:-the beginning}, at ${sha}."