Select more than one file at a time
Moving or deleting five files meant doing it five times, each with its own confirm. Rows now select the way they do in a file manager: a plain click replaces the selection, ctrl or cmd adds and removes one, shift takes the run from the last row clicked, clicking past the last row or pressing Escape clears it. Two or more selected raises a bar with Move to... and Delete, and the row menu offers the same for the whole selection. The move is one `FileNode/set` rather than a loop, and not only for the round trip: a loop would apply half the moves and then throw, leaving a selection split across two folders with nothing saying which half went. One call is one answer, and `notUpdated` names whatever the server refused. Right-clicking inside the selection acts on all of it; right-clicking outside means you meant that row, so the selection follows the pointer rather than the menu quietly applying to something off-screen. A drag carries the whole selection the same way, which is why the payload is now a list -- and why a drop is refused unless every file in it can land, since a drag that moves four of five and skips the fifth is worse than one that will not start. A selection belongs to the folder it was made in, so changing folder or account drops it: rows left selected off-screen make the delete two folders later a surprise.
This commit is contained in:
@@ -24,7 +24,7 @@ describe("what a switch to another account keeps", () => {
|
||||
children: {},
|
||||
dirIds: [],
|
||||
treeLoaded: false,
|
||||
draggingId: null,
|
||||
draggingIds: [],
|
||||
error: null,
|
||||
});
|
||||
});
|
||||
@@ -41,14 +41,14 @@ describe("what a switch to another account keeps", () => {
|
||||
|
||||
it("drops a drag that was in flight", () => {
|
||||
// Its id belongs to the other account and would name a different node here.
|
||||
expect(emptyForAccount("b").draggingId).toBeNull();
|
||||
expect(emptyForAccount("b").draggingIds).toEqual([]);
|
||||
});
|
||||
|
||||
it("names every piece of per-account state", () => {
|
||||
// Add a per-account field to the store and forget it here, and this fails
|
||||
// rather than the field quietly following someone into another account.
|
||||
expect(Object.keys(emptyForAccount(null)).sort()).toEqual(
|
||||
["accountId", "children", "dirIds", "draggingId", "error", "nodes", "treeLoaded"],
|
||||
["accountId", "children", "dirIds", "draggingIds", "error", "nodes", "treeLoaded"],
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user