Use an example address, and the right name, in the test fixtures #113

New Issue

Closed

opened 2026-08-27 21:09:08 +00:00 by jcoffey-dev · 0 comments

jcoffey-dev commented

2026-08-27 21:09:08 +00:00

Owner

Two things, and one of them isn't what it looked like.

The address was real; it shouldn't be

An organizer fixture was built from a real, routable address:

const me = makeParticipant("[email protected]", …);

Every other fixture uses example.org or example.com, and this repository is public — so that one was a personal address sitting in public source for no reason. The test asserts roles and participation status and never reads the value. It's [email protected] now.

The names were wrong in the other direction

Three fixtures across two files said "John Ellis", which is not the maintainer's name — it's John Coffey. Being a name rather than a routable address it leaked nothing, but it was simply incorrect, and incorrect in the sort of place nobody rereads:

web/src/lib/__tests__/mdn.test.ts
web/src/lib/__tests__/signatureHtml.test.ts (×2, in a pasted-Word signature sample)

They're separate questions, so they get separate answers

The address is fictional because it's an address. The name is real because it's right. A message from [email protected] signed John Coffey is exactly what these tests mean.

Context

Found while checking whether the repo leaked anything about the host it runs on. It does not — nginx.example.conf, Caddyfile.example and deploy.example.sh are the generic examples they claim to be, and the real nginx configs and deploy scripts live in a private repository. A grep for production hostnames, paths and addresses across all tracked files turns up nothing else.

333 web and 77 server tests pass. npm run typecheck clean.

🤖 Generated with Claude Code

Merged 2026-08-27 as coffey-labs/ihasmail@8cc12b8f56

_{Rebuilt from: git history, session transcript.}

Two things, and one of them isn't what it looked like. ### The address was real; it shouldn't be An organizer fixture was built from a real, routable address: ```js const me = makeParticipant("[email protected]", …); ``` Every other fixture uses `example.org` or `example.com`, and this repository is public — so that one was a personal address sitting in public source for no reason. The test asserts roles and participation status and never reads the value. It's `[email protected]` now. ### The names were wrong in the other direction Three fixtures across two files said **"John Ellis"**, which is not the maintainer's name — it's John Coffey. Being a name rather than a routable address it leaked nothing, but it was simply incorrect, and incorrect in the sort of place nobody rereads: - `web/src/lib/__tests__/mdn.test.ts` - `web/src/lib/__tests__/signatureHtml.test.ts` (×2, in a pasted-Word signature sample) ### They're separate questions, so they get separate answers The address is fictional because it's an address. The name is real because it's right. A message from `[email protected]` signed *John Coffey* is exactly what these tests mean. ### Context Found while checking whether the repo leaked anything about the host it runs on. It does not — `nginx.example.conf`, `Caddyfile.example` and `deploy.example.sh` are the generic examples they claim to be, and the real nginx configs and deploy scripts live in a private repository. A grep for production hostnames, paths and addresses across all tracked files turns up nothing else. 333 web and 77 server tests pass. `npm run typecheck` clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) **Merged** 2026-08-27 as coffey-labs/ihasmail@8cc12b8f56dd <sub>Rebuilt from: git history, session transcript.</sub>

This repo is archived. You cannot comment on issues.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: coffey-labs/ihasmail-github-archive#113