jcoffey-dev
9435115ab7
Saved, shareable multi-panel dashboards (table/line/bar/single-stat panels via gridstack + uPlot, global + per-panel time range, JSON export/import) and threshold/absence alert rules with an ok/pending/firing evaluator and webhook/Slack/PagerDuty delivery. - New /metadata component: Postgres control-plane store for dashboards, panels, notification targets, alert rules/state, and delivery log -- see docs/phase-3-dashboard-design.md for why ClickHouse's MergeTree family isn't a fit for this access pattern (needs real row-level locking and read-your-writes consistency). - api/internal/dashboards: dashboard/panel CRUD, pure -- panel query execution stays client-side, reusing the existing /query endpoint. - New /alerting service: rule/target CRUD, a ticker-driven evaluator (claim-then-evaluate concurrency control, transactional-outbox delivery, query errors and threshold zero-rows never coerced into a false transition) and webhook/Slack/PagerDuty delivery with retry/backoff. See docs/phase-3-alerting-design.md for the full state-machine design and the four correctness properties it implements. - web: /dashboards and /alerts UIs; cli: sentryctl dashboards/alerts list/get/apply, seeding a future Terraform provider's JSON contract. - hack/alert-load-test: 500 rules against real ClickHouse data, real measured results in docs/phase-3-runbook.md. Five real bugs found by actually running this against a live stack (documented in the runbook, not just fixed silently): a latent Phase 2 bug where ClickHouse rejected the timestamp format used for earliest=/latest= queries; a "now" literal token injected into query text; a GridStack/uPlot layout-timing race; JS's Date.parse being too lenient to use as a timestamp-detection heuristic; a rule's "enabled" field silently defaulting to false when omitted; and the evaluator's claim-batch-size and worker-pool-concurrency defaulting to the same value, causing 500 concurrently-due rules to take 125s to cycle through instead of the configured 60s.
49 lines
1.1 KiB
Go
49 lines
1.1 KiB
Go
package delivery
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
)
|
|
|
|
// slackPayload is Slack's incoming-webhook shape: {"text": "..."}. No
|
|
// user template for this kind -- see webhook.go's BuildPayload doc
|
|
// comment for why (thin formatter, not a user-configurable path).
|
|
type slackPayload struct {
|
|
Text string `json:"text"`
|
|
}
|
|
|
|
func buildSlackPayload(event Event) ([]byte, error) {
|
|
var text string
|
|
switch event.EventType {
|
|
case "firing":
|
|
text = fmt.Sprintf(":rotating_light: *%s* is firing", event.RuleName)
|
|
if event.Value != nil && event.ThresholdValue != nil {
|
|
text += fmt.Sprintf(" (value %.4g %s %.4g)", *event.Value, comparatorSymbol(event.Comparator), *event.ThresholdValue)
|
|
}
|
|
case "resolved":
|
|
text = fmt.Sprintf(":white_check_mark: *%s* resolved", event.RuleName)
|
|
default:
|
|
text = fmt.Sprintf("%s: %s", event.RuleName, event.EventType)
|
|
}
|
|
return json.Marshal(slackPayload{Text: text})
|
|
}
|
|
|
|
func comparatorSymbol(c string) string {
|
|
switch c {
|
|
case "gt":
|
|
return ">"
|
|
case "gte":
|
|
return ">="
|
|
case "lt":
|
|
return "<"
|
|
case "lte":
|
|
return "<="
|
|
case "eq":
|
|
return "=="
|
|
case "ne":
|
|
return "!="
|
|
default:
|
|
return c
|
|
}
|
|
}
|