Full rebrand across cosmetic branding, code identifiers, and infrastructure/data-plane naming, using the supplied Cairn OBS logo package. Cosmetic: favicon/logo swap (also closes a stale license-audit finding -- the old favicon was SvelteKit's unreplaced scaffold logo), new centered welcome landing page, larger/legible sidebar logo, page titles, CLAUDE.md/README/docs prose. Code identifiers: Go module path github.com/sentry/sentry -> github.com/cairnobs/cairnobs across all 13 modules and ~91 files (protoc regenerated); Rust crates sentry-agent/sentry-parser/sentry-search -> cairnobs-*; CLI sentryctl -> cairnobsctl; Terraform provider fully renamed (sentry_dashboard etc. -> cairnobs_dashboard, provider type, env vars); every session/auth cookie name; agent config paths and Windows service identity. Deliberately preserved: the gRPC wire protocol's protobuf packages (sentry.logs.v1, sentry.agent.v1) and their Go import directory (proto/sentry/...) -- renaming the wire-level package would break every currently-deployed agent binary (confirmed two real hosts, including mail.inbuxa.com, are actively streaming through this exact contract) until rebuilt and redeployed in lockstep with an ingest cutover. Only the Go module path wrapping the generated code changes. Infrastructure: every docker-compose container name (root and three component-level compose files); the Helm chart (directory, Chart.yaml, named-template helpers, all templates, values.yaml image repos); Kubernetes Operator (CRD group sentry.io -> cairnobs.io, both CRD YAML files, Go identifiers, RBAC markers); the coupled enterprise/tenantcrd package. Caught and fixed real path-coupling bugs along the way: the Helm chart's search/ingest volume mounts and the dev-only-credential detection constant vs. docker-compose.yml's literal values had to move together or a security warning would have silently stopped firing. Data plane: Postgres database sentry_metadata -> cairnobs_metadata and role sentry -> cairnobs; ClickHouse database sentry -> cairnobs; Kafka topic sentry.logs.raw -> cairnobs.logs.raw and its consumer groups. Source-level defaults, docker-compose.yml, and every migrate.sh/ provision script default updated together; already-applied migration files left untouched per this repo's immutable-migration convention. Verified at every layer: all 13 Go modules build/vet/test clean, both Rust workspaces (agent, search) build/clippy/test clean, npm run check/ build clean, docker compose config validates on all four compose files. Live-verified against a real docker stack multiple times through this work, including a final fresh-volume run confirming the actual renamed Postgres database/role, ClickHouse database, and Kafka topic all work end to end with a real login and query, zero console errors.
173 lines
7.0 KiB
Go
173 lines
7.0 KiB
Go
// Tests run a real gRPC server in-process (net.Listen on an ephemeral
|
|
// port, a real grpc.Server) implementing SearchServiceServer, so these
|
|
// exercise the actual wire protocol Client.Search sends, not a mocked
|
|
// interface -- proving TenantId is set on the real SearchRequest that
|
|
// would reach `search`, and that Client fails closed exactly the way
|
|
// enterprise/internal/chrunner.Registry.RunSQL does for ClickHouse.
|
|
package searchclient
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"net"
|
|
"testing"
|
|
|
|
"google.golang.org/grpc"
|
|
|
|
"github.com/cairnobs/cairnobs/api/authz"
|
|
searchv1 "github.com/cairnobs/cairnobs/proto/sentry/search/v1"
|
|
)
|
|
|
|
type fakeSearchServer struct {
|
|
searchv1.UnimplementedSearchServiceServer
|
|
lastRequest *searchv1.SearchRequest
|
|
recordIDs []string
|
|
}
|
|
|
|
func (f *fakeSearchServer) Search(_ context.Context, req *searchv1.SearchRequest) (*searchv1.SearchResponse, error) {
|
|
f.lastRequest = req
|
|
return &searchv1.SearchResponse{RecordIds: f.recordIDs}, nil
|
|
}
|
|
|
|
// fakeTenantChecker is an in-memory TenantChecker -- active lists which
|
|
// tenant IDs count as active, everything else answers false (not an
|
|
// error), matching rbacstore.TenantIsActive's shape (a nonexistent
|
|
// tenant is "not active," not a lookup failure).
|
|
type fakeTenantChecker struct {
|
|
active map[string]bool
|
|
err error
|
|
}
|
|
|
|
func (f *fakeTenantChecker) TenantIsActive(_ context.Context, tenantID string) (bool, error) {
|
|
if f.err != nil {
|
|
return false, f.err
|
|
}
|
|
return f.active[tenantID], nil
|
|
}
|
|
|
|
func newTestServer(t *testing.T, tenants TenantChecker) (*Client, *fakeSearchServer) {
|
|
t.Helper()
|
|
lis, err := net.Listen("tcp", "127.0.0.1:0")
|
|
if err != nil {
|
|
t.Fatalf("listening: %v", err)
|
|
}
|
|
fake := &fakeSearchServer{recordIDs: []string{"id-1", "id-2"}}
|
|
srv := grpc.NewServer()
|
|
searchv1.RegisterSearchServiceServer(srv, fake)
|
|
go func() { _ = srv.Serve(lis) }()
|
|
t.Cleanup(srv.Stop)
|
|
|
|
client, err := Dial(lis.Addr().String(), tenants)
|
|
if err != nil {
|
|
t.Fatalf("Dial: %v", err)
|
|
}
|
|
t.Cleanup(func() { _ = client.Close() })
|
|
return client, fake
|
|
}
|
|
|
|
func TestSearchForwardsTenantIDFromContext(t *testing.T) {
|
|
client, fake := newTestServer(t, &fakeTenantChecker{active: map[string]bool{"acme": true}})
|
|
ctx := authz.WithIdentity(context.Background(), authz.Identity{TenantID: "acme", Role: authz.RoleViewer})
|
|
|
|
ids, err := client.Search(ctx, "error", 10)
|
|
if err != nil {
|
|
t.Fatalf("Search: %v", err)
|
|
}
|
|
if len(ids) != 2 {
|
|
t.Fatalf("got %d record ids, want 2", len(ids))
|
|
}
|
|
if fake.lastRequest.TenantId != "acme" {
|
|
t.Fatalf("TenantId sent to search = %q, want acme", fake.lastRequest.TenantId)
|
|
}
|
|
if fake.lastRequest.Query != "error" || fake.lastRequest.Limit != 10 {
|
|
t.Fatalf("unexpected request: %+v", fake.lastRequest)
|
|
}
|
|
}
|
|
|
|
func TestSearchRefusesWithNoIdentity(t *testing.T) {
|
|
client, fake := newTestServer(t, &fakeTenantChecker{active: map[string]bool{"acme": true}})
|
|
|
|
if _, err := client.Search(context.Background(), "error", 10); err == nil {
|
|
t.Fatal("expected Search to refuse a request with no authenticated identity in context")
|
|
}
|
|
if fake.lastRequest != nil {
|
|
t.Fatal("expected the gRPC call to never reach the server when there's no identity")
|
|
}
|
|
}
|
|
|
|
func TestSearchRefusesIdentityWithNoTenant(t *testing.T) {
|
|
client, fake := newTestServer(t, &fakeTenantChecker{active: map[string]bool{"acme": true}})
|
|
// RoleService identities carry no TenantID -- see api/authz.Identity's
|
|
// doc comment. /alerting never calls search directly today, but the
|
|
// fail-closed behavior must hold regardless of how this arises.
|
|
ctx := authz.WithIdentity(context.Background(), authz.Identity{Role: authz.RoleService})
|
|
|
|
if _, err := client.Search(ctx, "error", 10); err == nil {
|
|
t.Fatal("expected Search to refuse an identity with no tenant")
|
|
}
|
|
if fake.lastRequest != nil {
|
|
t.Fatal("expected the gRPC call to never reach the server when the identity has no tenant")
|
|
}
|
|
}
|
|
|
|
func TestSearchDifferentTenantsSendDifferentTenantIDs(t *testing.T) {
|
|
client, fake := newTestServer(t, &fakeTenantChecker{active: map[string]bool{"acme": true, "globex": true}})
|
|
|
|
ctxA := authz.WithIdentity(context.Background(), authz.Identity{TenantID: "acme", Role: authz.RoleViewer})
|
|
if _, err := client.Search(ctxA, "q", 5); err != nil {
|
|
t.Fatalf("Search (acme): %v", err)
|
|
}
|
|
if fake.lastRequest.TenantId != "acme" {
|
|
t.Fatalf("TenantId = %q, want acme", fake.lastRequest.TenantId)
|
|
}
|
|
|
|
ctxB := authz.WithIdentity(context.Background(), authz.Identity{TenantID: "globex", Role: authz.RoleViewer})
|
|
if _, err := client.Search(ctxB, "q", 5); err != nil {
|
|
t.Fatalf("Search (globex): %v", err)
|
|
}
|
|
if fake.lastRequest.TenantId != "globex" {
|
|
t.Fatalf("TenantId = %q, want globex", fake.lastRequest.TenantId)
|
|
}
|
|
}
|
|
|
|
// TestSearchRefusesMidProvisioningTenant is Phase 4 task 8's item 4
|
|
// adversarial probe (see /docs/phase-4-isolation-design.md's
|
|
// verification plan and api/queryapi/tenant_isolation_gap_test.go),
|
|
// closed here without needing Docker or a live Postgres: a tenant that
|
|
// exists (an authenticated identity can carry its ID -- e.g. right
|
|
// after enterprise-auth -create-tenant / -grant-membership-* but before
|
|
// enterprise-api -provision-tenant runs) but isn't active yet must be
|
|
// refused, not silently served a fresh empty index. This is exactly the
|
|
// gap search/src/registry.rs's IndexRegistry can't close on its own
|
|
// (see this package's doc comment) -- proving it here, at the one layer
|
|
// that actually has rbacstore access, is what makes the guarantee real.
|
|
func TestSearchRefusesMidProvisioningTenant(t *testing.T) {
|
|
client, fake := newTestServer(t, &fakeTenantChecker{active: map[string]bool{"acme": true}})
|
|
// "pending" is deliberately absent from the active set -- simulates
|
|
// a tenant row that exists in rbacstore (provisioning, or even
|
|
// active-but-not-yet-credentialed) without needing a real tenants
|
|
// table to prove the point: fakeTenantChecker.active only ever
|
|
// answers "true" for tenants explicitly marked active, exactly like
|
|
// rbacstore.TenantIsActive does for a real 'provisioning' row.
|
|
ctx := authz.WithIdentity(context.Background(), authz.Identity{TenantID: "pending", Role: authz.RoleViewer})
|
|
|
|
if _, err := client.Search(ctx, "error", 10); err == nil {
|
|
t.Fatal("expected Search to refuse a tenant that isn't active yet, not silently search an empty index for it")
|
|
}
|
|
if fake.lastRequest != nil {
|
|
t.Fatal("expected the gRPC call to never reach the server for a non-active tenant -- the whole point is refusing before search/src/registry.rs ever gets a chance to open-or-create an index for it")
|
|
}
|
|
}
|
|
|
|
func TestSearchPropagatesTenantCheckerError(t *testing.T) {
|
|
client, fake := newTestServer(t, &fakeTenantChecker{err: fmt.Errorf("boom")})
|
|
ctx := authz.WithIdentity(context.Background(), authz.Identity{TenantID: "acme", Role: authz.RoleViewer})
|
|
|
|
if _, err := client.Search(ctx, "error", 10); err == nil {
|
|
t.Fatal("expected Search to fail closed when the tenant status check itself errors, not treat an error as \"not active but otherwise fine\"")
|
|
}
|
|
if fake.lastRequest != nil {
|
|
t.Fatal("expected the gRPC call to never reach the server when the tenant check errored")
|
|
}
|
|
}
|