Phase 1: Windows log collection + full-text search
Extends the agent, ingest, storage, api, and web with Windows Event Log/ETW sourcing and Tantivy-backed free-text search, per the approved Phase 1 plan. - CLAUDE.md: materialized on disk (never existed as a file before) with a new Phase 1 "done looks like" section. - agent: Windows Event Log (EvtSubscribe) and ETW sources, Windows service wrapper (install/uninstall/run-service), both feature- and target_os-gated so Linux builds/tests/clippy stay unaffected. Also fixed two pre-existing Phase 0 clippy gaps (dead-code on default-features-only builds, a type-inference edge case) found while testing every feature combination properly for the first time. UNVERIFIED on real Windows -- no Windows toolchain existed anywhere in the build environment; flagged prominently in three places. - proto/ingest: new record_id field, assigned once server-side in ingest's gRPC front end so ClickHouse and Tantivy agree on the same ID for the same record. - storage: record_id column + bloom filter index, verified against a live ClickHouse. - search: new service, Tantivy index, rskafka consumer as an independent second consumer group on the same Redpanda topic ingest already reads. - api/web: new /search endpoint and page, sharing the query page's result-table shape and component. - hack/windows-fixture: sends realistic Windows-shaped data straight to ingest, so the pipeline's handling of it is verifiable without a Windows host. Verified end-to-end on the live docker-compose stack: the same record_id comes back from both /query and /search for the same log line, including for windows-fixture's synthetic Windows Event Log data. Real bugs found and fixed along the way: api/Dockerfile missing proto/ in its build context, search's logs being completely silent (RUST_LOG gap), and search/target/ missing from .gitignore/.dockerignore.
This commit is contained in:
@@ -0,0 +1,33 @@
|
||||
syntax = "proto3";
|
||||
|
||||
package sentry.search.v1;
|
||||
|
||||
option go_package = "github.com/sentry/sentry/proto/sentry/search/v1;searchv1";
|
||||
|
||||
// SearchService is the full-text search index (Tantivy-backed) that
|
||||
// `api` calls to resolve a free-text query into matching record_ids,
|
||||
// which `api` then joins back against ClickHouse. Internal service-to-
|
||||
// service call, same gRPC-first convention as agent<->ingest — see
|
||||
// /docs/architecture.md and /search/README.md.
|
||||
service SearchService {
|
||||
rpc Search(SearchRequest) returns (SearchResponse);
|
||||
}
|
||||
|
||||
message SearchRequest {
|
||||
// Free-text query passed to Tantivy's query parser as-is. Supports
|
||||
// phrase queries ("exact phrase") and wildcards (foo*) per Tantivy's
|
||||
// own query syntax — see /search/README.md for exactly what that does
|
||||
// and doesn't support in Phase 1.
|
||||
string query = 1;
|
||||
|
||||
// Max results to return. 0 (unset) uses the service's own default.
|
||||
uint32 limit = 2;
|
||||
}
|
||||
|
||||
message SearchResponse {
|
||||
// record_ids of matching logs, most-relevant first. Callers join these
|
||||
// back against ClickHouse's `logs.record_id` column to get full rows —
|
||||
// this service only ever returns IDs, never row data, so it stays a
|
||||
// pure text index rather than a second copy of the row.
|
||||
repeated string record_ids = 1;
|
||||
}
|
||||
Reference in New Issue
Block a user